Fix skip update mechanism #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <[email protected]>
ulucinar
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Thanks @sergenyalcin, lgtm. Let's release this fix in a patch and re-validate it in upbound/provider-aws. Please also see: crossplane-contrib/provider-upjet-aws#1167
| @@ -152,8 +150,10 @@ func (t *tester) prepareConfig() (*config.TestCase, []config.Resource, error) { | |||
| if disableImport == "true" { | |||
| tc.SkipImport = true | |||
| } | |||
| if updateParameter == "" { | |||
There was a problem hiding this comment.
Does an uptest.upbound.io/disable-import annotation on a dependency resource of an example manifest has any effect?
There was a problem hiding this comment.
The update is for only root resources now. But import for every resource in the manifest. So, the disable-import has an effect on the dependency resources.
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes the skipping update mechanism. In the current behavior, the uptest skips the update test if at least one resource does not have an update-parameter annotation in the test manifest.
With this fix, we will skip if the Root does not have the update-parameter annotation. Just to remind you, we are only doing update tests for Root resources. Please see: https://github.com/upbound/uptest/blob/ac36a0c985cc93e8e5dc445257e3f2122086bb9b/internal/templates/01-update.yaml.tmpl#L10
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested locally